holetron-lab/fleet-memory
1
0
Fork 0
Code Releases Packages Activity Actions

fix(openclaw): add warn log and tests for CLI mode no-op in waitForReady (#799)

Browse source 
Follow-up to #764. Upgrades the silent debug log in waitForReady to
log.warn so unexpected calls before service.start() are visible, and
adds tests covering the CLI mode no-op path.
This commit is contained in:
Nicolò Boschi 2026-03-31 09:25:52 +02:00 committed by GitHub
parent 41025c3b7c
commit d3d2684b11
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 21 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
hindsight-integrations/openclaw/src/index.test.ts
View file

@ -425,3 +425,23 @@ describe('truncateRecallQuery', () => {
expect(truncated.length).toBeLessThanOrEqual(180);
});
});
// ---------------------------------------------------------------------------
// waitForReady — CLI mode no-op (initPromise is null before service.start())
// ---------------------------------------------------------------------------
describe('waitForReady (CLI mode)', () => {
it('returns without error when initPromise is null (service.start not called)', async () => {
// The module sets up global.__hindsightClient on import.
// In test context, service.start() is never called so initPromise remains null.
const hindsight = (global as any).__hindsightClient;
expect(hindsight).toBeDefined();
// Should resolve without throwing
await expect(hindsight.waitForReady()).resolves.toBeUndefined();
});
it('getClient returns null when service.start not called', () => {
const hindsight = (global as any).__hindsightClient;
expect(hindsight.getClient()).toBeNull();
});
});

2
hindsight-integrations/openclaw/src/index.ts
View file

@ -134,7 +134,7 @@ if (typeof global !== 'undefined') {
// If initPromise is null, it means service.start() hasn't been called yet
// (CLI mode, not gateway mode). Hooks should gracefully no-op.
if (!initPromise) {
debug('[Hindsight] waitForReady called but initPromise is null (gateway not started)');
log.warn('waitForReady called before service.start() — hooks will no-op (expected in CLI mode)');
return;
}
try {