holetron-lab/fleet-memory
1
0
Fork 0
Code Releases Packages Activity Actions

fix(openclaw): remove unused imports, retry health check, suppress unhandled rejection (#373)

Browse source 
- Remove unused `fs` and `execSync` imports from `embed-manager.ts`
- Remove unused `join` import from `index.ts`
- Add retry logic to external API health check (3 attempts, 2s delay) —
  container DNS may not be ready on first boot
- Use ES2022 `{ cause: error }` for better error chain preservation
- Add `.catch(() => {})` to `initPromise` to suppress Node.js unhandled
  rejection warnings (error is properly handled later in `service.start()`)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Anton Evseev 2026-02-16 19:02:19 +10:00 committed by GitHub
parent 7dad9da02d
commit d5e62162e8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 27 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
hindsight-integrations/openclaw/src/embed-manager.ts
View file

@ -1,8 +1,6 @@
import { spawn, ChildProcess } from 'child_process';
import { promises as fs } from 'fs';
import { join } from 'path';
import { homedir } from 'os';
import { execSync } from 'child_process';
export class HindsightEmbedManager {
private process: ChildProcess | null = null;

41
hindsight-integrations/openclaw/src/index.ts
View file

@ -1,7 +1,7 @@
import type { MoltbotPluginAPI, PluginConfig } from './types.js';
import { HindsightEmbedManager } from './embed-manager.js';
import { HindsightClient } from './client.js';
import { join, dirname } from 'path';
import { dirname } from 'path';
import { fileURLToPath } from 'url';
// Module-level state
@ -22,8 +22,8 @@ if (typeof global !== 'undefined') {
(global as any).__hindsightClient = {
getClient: () => client,
waitForReady: async () => {
if (isInitialized) return;
if (initPromise) await initPromise;
if (isInitialized) {return;}
if (initPromise) {await initPromise;}
},
/**
* Get a client configured for a specific agent context.
@ -31,7 +31,7 @@ if (typeof global !== 'undefined') {
* Also ensures the bank mission is set on first use.
*/
getClientForContext: async (ctx: PluginHookAgentContext | undefined) => {
if (!client) return null;
if (!client) {return null;}
const config = currentPluginConfig || {};
const bankId = deriveBankId(ctx, config);
client.setBankId(bankId);
@ -235,19 +235,31 @@ function detectExternalApi(pluginConfig?: PluginConfig): {
/**
* Health check for external Hindsight API.
* Retries up to 3 times with 2s delay — container DNS may not be ready on first boot.
*/
async function checkExternalApiHealth(apiUrl: string): Promise<void> {
const healthUrl = `${apiUrl.replace(/\/$/, '')}/health`;
console.log(`[Hindsight] Checking external API health at ${healthUrl}...`);
try {
const response = await fetch(healthUrl, { signal: AbortSignal.timeout(10000) });
if (!response.ok) {
throw new Error(`HTTP ${response.status}: ${response.statusText}`);
const maxRetries = 3;
const retryDelay = 2000;
for (let attempt = 1; attempt <= maxRetries; attempt++) {
try {
console.log(`[Hindsight] Checking external API health at ${healthUrl}... (attempt ${attempt}/${maxRetries})`);
const response = await fetch(healthUrl, { signal: AbortSignal.timeout(10000) });
if (!response.ok) {
throw new Error(`HTTP ${response.status}: ${response.statusText}`);
}
const data = await response.json() as { status?: string };
console.log(`[Hindsight] External API health: ${JSON.stringify(data)}`);
return;
} catch (error) {
if (attempt < maxRetries) {
console.log(`[Hindsight] Health check attempt ${attempt} failed, retrying in ${retryDelay}ms...`);
await new Promise(resolve => setTimeout(resolve, retryDelay));
} else {
throw new Error(`Cannot connect to external Hindsight API at ${apiUrl}: ${error}`, { cause: error });
}
}
const data = await response.json() as { status?: string };
console.log(`[Hindsight] External API health: ${JSON.stringify(data)}`);
} catch (error) {
throw new Error(`Cannot connect to external Hindsight API at ${apiUrl}: ${error}`);
}
}
@ -401,7 +413,8 @@ export default function (api: MoltbotPluginAPI) {
}
})();
// Don't await - let it initialize in background
// Suppress unhandled rejection — service.start() will await and handle errors
initPromise.catch(() => {});
// Register background service for cleanup
console.log('[Hindsight] Registering service...');