8d731f2e5f
* feat: implement hierarchical configuration (system, tenant, bank) * feat: implement hierarchical configuration (system, tenant, bank) * docs: add instructions for hierarchical config in CLAUDE.md * feat: add ENABLE_BANK_CONFIG_API flag (disabled by default) - Add HINDSIGHT_API_ENABLE_BANK_CONFIG_API env var (default: false) - Return 403 Forbidden from bank config endpoints when disabled - Update tests to enable the flag - Update CLAUDE.md documentation This provides security control over the bank configuration API, ensuring it's only accessible when explicitly enabled. * docs: add hierarchical configuration section * feat(cli): add bank config commands (config, set-config, reset-config) - Add 'hindsight bank config' to view bank configuration - Add 'hindsight bank set-config' to update LLM settings per bank - Add 'hindsight bank reset-config' to reset to defaults - Implements client API calls to new bank config endpoints * fix(cli): fix compilation errors in bank config commands - Fix type signature: use ApiClient instead of api::Client - Fix confirmation: use ui::prompt_confirmation instead of ui::confirm - Fix error handling: use anyhow! macro instead of errors::Error - Fix type conversion: convert HashMap to serde_json::Map for API call * feat: implement type-safe hierarchical config with bank overrides Implements a production-ready hierarchical configuration system that prevents accidentally using global defaults when bank-specific overrides exist. - Created StaticConfigProxy that wraps HindsightConfig - get_config() now returns proxy that blocks access to bank-configurable fields - Raises ConfigFieldAccessError with clear message when accessing configurable fields - Added _get_raw_config() for internal use only - Forces developers to use resolve_full_config(bank_id, context) for bank settings - Added resolve_full_config() method that returns complete HindsightConfig - Resolves hierarchy: Global (env) → Tenant → Bank - No caching to support multi-server deployments (always fresh from DB) - LLM provider pooling handles expensive operations separately - Updated entire retain pipeline to pass resolved config through call chain - memory_engine.py: Resolves config at top level where bank_id/context available - orchestrator.py: Accepts and passes config to fact_extraction - fact_extraction.py: Uses passed config instead of get_config() - utils.py: Added optional config param for backward compatibility - consolidator.py: Uses resolve_full_config() for enable_observations check - memory_engine.py: Resolves config before triggering consolidation - Renamed "Memory Bank" to "Bank Configuration" with tabs - Combined Stats and Operations into "General" tab - Consolidated Profile and Configuration into "Configuration" tab - Moved Actions dropdown to page level (outside tabs) - Created new component for managing bank-specific config - Displays configurable fields: retain_chunk_size, retain_extraction_mode, etc. - Edit via dialog with form validation - Reset to defaults via AlertDialog confirmation - Shows field IDs in monospace for clarity - Visual separation with borders and hover effects - Removed inline edit mode, switched to dialog-based editing - Separate dialogs for Disposition and Mission editing - Read-only display with clear edit buttons - Removed duplicate stats cards and operations - bank-stats-view.tsx: Overview statistics (memories, links, documents, pending ops) - bank-operations-view.tsx: Background operations table with filtering **Problem**: Consolidation always used global enable_observations, ignoring bank overrides **Root Cause**: consolidator.py called get_config() instead of resolving bank-specific config **Solution**: Pass resolved config through the entire pipeline **Problem**: asyncpg returning JSONB as JSON string instead of parsed dict **Solution**: Explicit JSON parsing in config_resolver.py with type checking - All 19 API integration tests pass - All 10 hierarchical config tests pass - Retain operations work correctly with bank-specific config - Consolidation respects bank-specific enable_observations setting - Updated developer/configuration.md with type-safe config access pattern - Added examples showing correct usage patterns - Documented ConfigFieldAccessError and resolution methods - get_config() now returns StaticConfigProxy (blocks configurable field access) - Code accessing bank-configurable fields must use resolve_full_config() - Clear migration path with helpful error messages Fixes hierarchical configuration to be production-ready with proper type safety. * refactor: remove LLM client pool and simplify config resolver Since LLM config (provider, model, api_key) is now static and not bank-configurable, the LLMClientPool is no longer needed. Changes: - Remove hindsight_api/llm_client_pool.py (no longer needed) - Remove memory_engine._get_bank_llm_config() (dead code, never called) - Simplify config_resolver.py by eliminating duplication between resolve_full_config() and get_bank_config() - get_bank_config() now calls resolve_full_config() and filters results - Remove outdated "LLM provider pooling" comments from docstrings All tests pass (10 hierarchical config tests, 19 API integration tests) * fix: update tests to use _get_raw_config() for configurable fields Fixed test fixtures that were accessing configurable fields (like enable_observations) from get_config(), which now raises ConfigFieldAccessError due to type-safe config access. Changes: - test_consolidation.py: Changed enable_observations fixture to use _get_raw_config() instead of get_config() - test_consolidation.py: Updated test_consolidation_returns_disabled_status to set bank config instead of mocking get_config() - test_link_expansion_retrieval.py: Changed fixture to use _get_raw_config() - test_observations.py: Changed disable_observations fixture to use _get_raw_config() - Regenerated OpenAPI spec and clients All 39 previously failing tests now pass. * fix: add missing config parameter to test calls of extract_facts_from_text() Fixed 45 test failures where tests were calling extract_facts_from_text() without the new required config parameter. Changes: - Added config=_get_raw_config() to all extract_facts_from_text() calls - Fixed test_main_module.py to patch _get_raw_config instead of get_config - Updated 6 test files with 37 function call sites All tests should now pass. * fix: add missing config parameter to test_skip_podcast_meta_commentary One more test was missing the config parameter for extract_facts_from_text().
87 lines
4.1 KiB
Text
87 lines
4.1 KiB
Text
hindsight_client_api/__init__.py
|
|
hindsight_client_api/api/__init__.py
|
|
hindsight_client_api/api/banks_api.py
|
|
hindsight_client_api/api/directives_api.py
|
|
hindsight_client_api/api/documents_api.py
|
|
hindsight_client_api/api/entities_api.py
|
|
hindsight_client_api/api/memory_api.py
|
|
hindsight_client_api/api/mental_models_api.py
|
|
hindsight_client_api/api/monitoring_api.py
|
|
hindsight_client_api/api/operations_api.py
|
|
hindsight_client_api/api_client.py
|
|
hindsight_client_api/api_response.py
|
|
hindsight_client_api/configuration.py
|
|
hindsight_client_api/exceptions.py
|
|
hindsight_client_api/models/__init__.py
|
|
hindsight_client_api/models/add_background_request.py
|
|
hindsight_client_api/models/async_operation_submit_response.py
|
|
hindsight_client_api/models/background_response.py
|
|
hindsight_client_api/models/bank_config_response.py
|
|
hindsight_client_api/models/bank_config_update.py
|
|
hindsight_client_api/models/bank_list_item.py
|
|
hindsight_client_api/models/bank_list_response.py
|
|
hindsight_client_api/models/bank_profile_response.py
|
|
hindsight_client_api/models/bank_stats_response.py
|
|
hindsight_client_api/models/budget.py
|
|
hindsight_client_api/models/cancel_operation_response.py
|
|
hindsight_client_api/models/chunk_data.py
|
|
hindsight_client_api/models/chunk_include_options.py
|
|
hindsight_client_api/models/chunk_response.py
|
|
hindsight_client_api/models/consolidation_response.py
|
|
hindsight_client_api/models/create_bank_request.py
|
|
hindsight_client_api/models/create_directive_request.py
|
|
hindsight_client_api/models/create_mental_model_request.py
|
|
hindsight_client_api/models/create_mental_model_response.py
|
|
hindsight_client_api/models/delete_document_response.py
|
|
hindsight_client_api/models/delete_response.py
|
|
hindsight_client_api/models/directive_list_response.py
|
|
hindsight_client_api/models/directive_response.py
|
|
hindsight_client_api/models/disposition_traits.py
|
|
hindsight_client_api/models/document_response.py
|
|
hindsight_client_api/models/entity_detail_response.py
|
|
hindsight_client_api/models/entity_include_options.py
|
|
hindsight_client_api/models/entity_input.py
|
|
hindsight_client_api/models/entity_list_item.py
|
|
hindsight_client_api/models/entity_list_response.py
|
|
hindsight_client_api/models/entity_observation_response.py
|
|
hindsight_client_api/models/entity_state_response.py
|
|
hindsight_client_api/models/features_info.py
|
|
hindsight_client_api/models/graph_data_response.py
|
|
hindsight_client_api/models/http_validation_error.py
|
|
hindsight_client_api/models/include_options.py
|
|
hindsight_client_api/models/list_documents_response.py
|
|
hindsight_client_api/models/list_memory_units_response.py
|
|
hindsight_client_api/models/list_tags_response.py
|
|
hindsight_client_api/models/memory_item.py
|
|
hindsight_client_api/models/mental_model_list_response.py
|
|
hindsight_client_api/models/mental_model_response.py
|
|
hindsight_client_api/models/mental_model_trigger.py
|
|
hindsight_client_api/models/operation_response.py
|
|
hindsight_client_api/models/operation_status_response.py
|
|
hindsight_client_api/models/operations_list_response.py
|
|
hindsight_client_api/models/recall_request.py
|
|
hindsight_client_api/models/recall_response.py
|
|
hindsight_client_api/models/recall_result.py
|
|
hindsight_client_api/models/reflect_based_on.py
|
|
hindsight_client_api/models/reflect_directive.py
|
|
hindsight_client_api/models/reflect_fact.py
|
|
hindsight_client_api/models/reflect_include_options.py
|
|
hindsight_client_api/models/reflect_llm_call.py
|
|
hindsight_client_api/models/reflect_mental_model.py
|
|
hindsight_client_api/models/reflect_request.py
|
|
hindsight_client_api/models/reflect_response.py
|
|
hindsight_client_api/models/reflect_tool_call.py
|
|
hindsight_client_api/models/reflect_trace.py
|
|
hindsight_client_api/models/retain_request.py
|
|
hindsight_client_api/models/retain_response.py
|
|
hindsight_client_api/models/tag_item.py
|
|
hindsight_client_api/models/token_usage.py
|
|
hindsight_client_api/models/tool_calls_include_options.py
|
|
hindsight_client_api/models/update_directive_request.py
|
|
hindsight_client_api/models/update_disposition_request.py
|
|
hindsight_client_api/models/update_mental_model_request.py
|
|
hindsight_client_api/models/validation_error.py
|
|
hindsight_client_api/models/validation_error_loc_inner.py
|
|
hindsight_client_api/models/version_response.py
|
|
hindsight_client_api/rest.py
|
|
hindsight_client_api_README.md
|