fleet-memory/hindsight-api/tests/test_mental_model_hooks.py

"""Unit tests for mental model operation validator hooks.

Tests that the operation validator hooks are called correctly for
mental model GET and refresh operations.
"""

import pytest

from hindsight_api.extensions.operation_validator import (
    MentalModelGetContext,
    MentalModelGetResult,
    MentalModelRefreshResult,
    OperationValidatorExtension,
    ValidationResult,
)


class TestMentalModelGetContextDataclass:
    """Tests for MentalModelGetContext dataclass."""

    def test_create_context(self):
        """Test creating a MentalModelGetContext."""
        from unittest.mock import MagicMock

        request_context = MagicMock()
        ctx = MentalModelGetContext(
            bank_id="bank-1",
            mental_model_id="mm-1",
            request_context=request_context,
        )

        assert ctx.bank_id == "bank-1"
        assert ctx.mental_model_id == "mm-1"
        assert ctx.request_context is request_context


class TestMentalModelGetResultDataclass:
    """Tests for MentalModelGetResult dataclass."""

    def test_create_result_success(self):
        """Test creating a successful MentalModelGetResult."""
        from unittest.mock import MagicMock

        request_context = MagicMock()
        result = MentalModelGetResult(
            bank_id="bank-1",
            mental_model_id="mm-1",
            request_context=request_context,
            output_tokens=250,
        )

        assert result.bank_id == "bank-1"
        assert result.mental_model_id == "mm-1"
        assert result.output_tokens == 250
        assert result.success is True
        assert result.error is None

    def test_create_result_failure(self):
        """Test creating a failed MentalModelGetResult."""
        from unittest.mock import MagicMock

        result = MentalModelGetResult(
            bank_id="bank-1",
            mental_model_id="mm-1",
            request_context=MagicMock(),
            output_tokens=0,
            success=False,
            error="Not found",
        )

        assert result.success is False
        assert result.error == "Not found"


class TestMentalModelRefreshResultDataclass:
    """Tests for MentalModelRefreshResult dataclass."""

    def test_create_result_with_all_fields(self):
        """Test creating a MentalModelRefreshResult with all fields."""
        from unittest.mock import MagicMock

        result = MentalModelRefreshResult(
            bank_id="bank-1",
            mental_model_id="mm-1",
            request_context=MagicMock(),
            query_tokens=50,
            output_tokens=500,
            context_tokens=0,
            facts_used=10,
            mental_models_used=2,
        )

        assert result.query_tokens == 50
        assert result.output_tokens == 500
        assert result.context_tokens == 0
        assert result.facts_used == 10
        assert result.mental_models_used == 2
        assert result.success is True
        assert result.error is None

    def test_create_result_failure(self):
        """Test creating a failed MentalModelRefreshResult."""
        from unittest.mock import MagicMock

        result = MentalModelRefreshResult(
            bank_id="bank-1",
            mental_model_id="mm-1",
            request_context=MagicMock(),
            query_tokens=50,
            output_tokens=0,
            context_tokens=0,
            facts_used=0,
            mental_models_used=0,
            success=False,
            error="Reflect failed",
        )

        assert result.success is False
        assert result.error == "Reflect failed"


class TestDefaultHookBehavior:
    """Tests for default (no-op) behavior of mental model hooks on OperationValidatorExtension."""

    @pytest.fixture
    def validator(self):
        """Create a concrete subclass for testing default behavior."""
        from unittest.mock import MagicMock

        # Create a concrete subclass that implements the abstract methods
        class TestValidator(OperationValidatorExtension):
            async def validate_retain(self, ctx):
                return ValidationResult.accept()

            async def validate_recall(self, ctx):
                return ValidationResult.accept()

            async def validate_reflect(self, ctx):
                return ValidationResult.accept()

        return TestValidator(config={})

    @pytest.mark.asyncio
    async def test_validate_mental_model_get_default_accepts(self, validator):
        """Test that default validate_mental_model_get accepts."""
        from unittest.mock import MagicMock

        ctx = MentalModelGetContext(
            bank_id="bank-1",
            mental_model_id="mm-1",
            request_context=MagicMock(),
        )

        result = await validator.validate_mental_model_get(ctx)

        assert result.allowed is True

    @pytest.mark.asyncio
    async def test_on_mental_model_get_complete_default_noop(self, validator):
        """Test that default on_mental_model_get_complete is a no-op."""
        from unittest.mock import MagicMock

        result = MentalModelGetResult(
            bank_id="bank-1",
            mental_model_id="mm-1",
            request_context=MagicMock(),
            output_tokens=100,
        )

        # Should not raise
        await validator.on_mental_model_get_complete(result)

    @pytest.mark.asyncio
    async def test_on_mental_model_refresh_complete_default_noop(self, validator):
        """Test that default on_mental_model_refresh_complete is a no-op."""
        from unittest.mock import MagicMock

        result = MentalModelRefreshResult(
            bank_id="bank-1",
            mental_model_id="mm-1",
            request_context=MagicMock(),
            query_tokens=50,
            output_tokens=500,
            context_tokens=0,
            facts_used=5,
            mental_models_used=1,
        )

        # Should not raise
        await validator.on_mental_model_refresh_complete(result)


class TestExportsAvailable:
    """Test that mental model hooks are properly exported."""

    def test_imports_from_extensions_package(self):
        """Test that all mental model types can be imported from hindsight_api.extensions."""
        from hindsight_api.extensions import (
            MentalModelGetContext,
            MentalModelGetResult,
            MentalModelRefreshResult,
        )

        assert MentalModelGetContext is not None
        assert MentalModelGetResult is not None
        assert MentalModelRefreshResult is not None